[UrJTAG-dev] compile failure on linux/arm: redeclaration of enumerator 'REG_R0'

[steve tell]

I'm having a compile-time error on linux for ARM (fedora 17 for armv7l, on
a google chromebook):

In file included from cmd_bfin.c:36:0:
../../include/urjtag/bfin.h:40:5: error: redeclaration of enumerator
'REG_R0'
In file included from /usr/include/signal.h:359:0,
from /usr/include/sys/wait.h:31,
from cmd_bfin.c:30:
/usr/include/sys/ucontext.h:42:3: note: previous definition of 'REG_R0'
was here


it seems that the REG_R0 through REG_R7 names in the bfin code conflict
with those names the system include file.
While i think the numeric values are in fact the same, we shouldn't count
on that. Simplest fix seems to be to change the blackfin stuff to use
BFIN_REG_* everywhere.

Other suggestions before I start constructing and testing this patch?
Steve

[Mike Frysinger]

Post by steve tell
I'm having a compile-time error on linux for ARM (fedora 17 for armv7l, on
../../include/urjtag/bfin.h:40:5: error: redeclaration of enumerator
'REG_R0'
In file included from /usr/include/signal.h:359:0,
from /usr/include/sys/wait.h:31,
/usr/include/sys/ucontext.h:42:3: note: previous definition of 'REG_R0'
was here
it seems that the REG_R0 through REG_R7 names in the bfin code conflict
with those names the system include file.
While i think the numeric values are in fact the same, we shouldn't count
on that. Simplest fix seems to be to change the blackfin stuff to use
BFIN_REG_* everywhere.

a simple workaround would be to add #define _SYS_UCONTEXT_H to the top of the
cmd_bfin.c file ...

making this change will require updating gdbproxy too.
-mike