Discussion:
[UrJTAG-dev] Patch: Changed configure.ac to make libtool linking work with cygwin/mingw and ftd2xx.
Åke Rehnman
2017-03-11 15:27:24 UTC
Permalink
Tested with cygwin, mingw32 and ubuntu...

Cygwin and ubuntu compiles smoothly but mingw complains a lot about
wrong format strings. But fixing mingw is another patch...

/Ake
Geert Stappers
2017-03-12 15:53:01 UTC
Permalink
Post by Åke Rehnman
Tested with cygwin, mingw32 and ubuntu...
Cygwin and ubuntu compiles smoothly but mingw complains a lot about
wrong format strings. But fixing mingw is another patch...
/Ake
From 4914746a5614aeca312d57192399b9284e5593d1 Mon Sep 17 00:00:00 2001
Date: Sat, 11 Mar 2017 16:07:31 +0100
Subject: [PATCH] Changed configure.ac to make libtool linking work with
cygwin/mingw and ftd2xx.
-no-undefined was added to src/Makefile to allow dynamic linking of ftd2xx
Inclusion of windows.h was moved out from sysdep.h and added to direct.c and
libftd2xx.c
Tested on Linux, it didn't break :-)

Patch is not yet applied due the several logical changes in a single patch.
(it is best practice to separate logical changes in different patches)
Let's first wait what other project members think about it.


Groeten
Geert Stappers
--
Leven en laten leven
Geert Stappers
2017-03-19 20:33:24 UTC
Permalink
Post by Geert Stappers
Post by Åke Rehnman
Tested with cygwin, mingw32 and ubuntu...
Cygwin and ubuntu compiles smoothly but mingw complains a lot about
wrong format strings. But fixing mingw is another patch...
/Ake
From 4914746a5614aeca312d57192399b9284e5593d1 Mon Sep 17 00:00:00 2001
Date: Sat, 11 Mar 2017 16:07:31 +0100
Subject: [PATCH] Changed configure.ac to make libtool linking work with
cygwin/mingw and ftd2xx.
-no-undefined was added to src/Makefile to allow dynamic linking of ftd2xx
Inclusion of windows.h was moved out from sysdep.h and added to direct.c and
libftd2xx.c
Tested on Linux, it didn't break :-)
Patch is not yet applied due the several logical changes in a single patch.
(it is best practice to separate logical changes in different patches)
Let's first wait what other project members think about it.
And after a week waiting I `git pushed` three parts of the original patch.

If there is some effect I didn't see, just say. Bring it to discussion.


Groeten
Geert Stappers
--
Leven en laten leven
Loading...